fix string multiplication bug

EclipseMenu · Dec 15, 2024 · a9323e3 · a9323e3
1 parent 8bd1766
commit a9323e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/value.cpp b/src/value.cpp
@@ -259,7 +259,11 @@ namespace rift {
             }
 
             auto const& str = isString() ? getString() : other.getString();
-            auto const& num = isString() ? other.toInteger() : toInteger();
+            auto num = isString() ? other.toInteger() : toInteger();
+
+            if (num <= 0) {
+                return geode::Ok(Value(""));
+            }
 
             std::string result;
             result.reserve(str.size() * num);

diff --git a/test/main.cpp b/test/main.cpp
@@ -111,6 +111,7 @@ int main() {
     RIFT_EVAL("('hello world' - 'hello ')[2] == 'r'", true); // string subtraction
     RIFT_TEST("{middlePad('#' * (progress * 4 / 10), 40, '-')} {progress}%", "----------####################---------- 50%", {{"progress", 50}});
     RIFT_TEST("{min(20, 40)}", "20");
+    RIFT_EVAL("-1 * 'hello'", ""); // making sure string multiplication with negative number is empty
 
     fmt::println("\nResults:\nTests passed: {}/{}\nTests failed: {}/{}", TEST_PASSED, TEST_COUNT, TEST_FAILED, TEST_COUNT);
     return TEST_FAILED;