Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): remove duplicated metadata in leader election role #26

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

AlexDouze
Copy link
Contributor

Remove duplicate metadata field in leader election role.
It causes our ArgoCD to complain about missing metadata.name.

@AlexDouze AlexDouze changed the title fix(helm): remove duplicate metadata in leader election role fix(helm): remove duplicated metadata in leader election role May 27, 2024
@AlexDouze AlexDouze force-pushed the remove-duplicate-metadata branch from 4ccff45 to b4f04ef Compare May 27, 2024 15:59
@oxyno-zeta oxyno-zeta self-assigned this Jun 11, 2024
@oxyno-zeta oxyno-zeta self-requested a review June 11, 2024 09:47
@oxyno-zeta
Copy link
Member

oxyno-zeta commented Jun 11, 2024

Hello @AlexDouze ! Thanks for this :) . We will add it :).

PS : Sorry for the late reply, I missed the PR

@oxyno-zeta oxyno-zeta merged commit 55b7e89 into EasyMile:master Jun 11, 2024
5 of 6 checks passed
@AlexDouze AlexDouze deleted the remove-duplicate-metadata branch June 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants