-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 18 functionality to return all parameters when parameter-names are not given #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames are not given
…arameter names are not given
fjugipe
requested review from
lukas-phaf,
Teddy-1000 and
Jeffrey-Vervoort-KNMI
February 8, 2024 11:59
API Unit Test Coverage Report
API Unit Test Coverage Summary
|
Teddy-1000
previously requested changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good, added some comments in dependencies.py
lukas-phaf
reviewed
Feb 8, 2024
lukas-phaf
reviewed
Feb 8, 2024
lukas-phaf
reviewed
Feb 9, 2024
lukas-phaf
reviewed
Feb 9, 2024
lukas-phaf
reviewed
Feb 9, 2024
lukas-phaf
approved these changes
Feb 9, 2024
Co-authored-by: Lukas Phaf <[email protected]>
fjugipe
dismissed
Teddy-1000’s stale review
February 12, 2024 07:40
Requested changes have been implemented, can be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Parameter name is no longer required in the query
Updates Swagger documentation with examples of time date
Improves error handling
Adds unit tests to edr api endpoints