Update landing page info #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-phaf
reviewed
Oct 15, 2024
api/openapi/openapi_metadata.py
Outdated
| openapi_metadata = { | ||
| "title": "Observations Europe EUMETNET", | ||
| "description": ( | ||
| "EDR data service for European environmental observations from EUMETNET," " co-funded by the European Union" |
There was a problem hiding this comment.
Isn't "environmental observations" to broad?
There was a problem hiding this comment.
Good question. It is the only type of observations we have. I don't really have any better suggestions either.
There was a problem hiding this comment.
... European meteorological observations ...
datastore/integration-test/response/metadata_collections_all_collections.json
Outdated
Show resolved
Hide resolved
lukas-phaf
reviewed
Nov 6, 2024
api/metadata_endpoints.py
Outdated
| "pressure", | ||
| "clouds", | ||
| "radiation", | ||
| ], | ||
| provider=Provider(name="RODEO", url="https://rodeo-project.eu/"), | ||
| contact=Contact(email="[email protected]"), |
There was a problem hiding this comment.
Do we want this contact to be different from the one at API level?
api/openapi/openapi_metadata.py
Outdated
| @@ -0,0 +1,15 @@ | |||
| openapi_metadata = { | |||
| "title": "Observations Europe EUMETNET", | |||
There was a problem hiding this comment.
I still don't like this title. It should say "EDR" and "API".
Teddy-1000
force-pushed
the
update-landingpage-info
branch
from
628382a to
939cfd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for updating landing page info.