Removed unreferenced time series and geo points #184
Conversation
|
Can we decouple this from the |
The regular DB cleanup is now triggered in a separate goroutine that is not invoked as part of handling a call to PutObservations. This simplifies code, avoids synchronization, and allows calls to PutObservations to return sooner.
…7_complete_cleanup
Fine by me, since i guess this is unrelated to that merge-backend... task anyway. But what's the best way to do that? |
|
Maybe the easiest is to create an altogether new branch (based off main) + PR ? |
|
Another solution is maybe to just merge into merge-backend-... as planned, but in addition create a new branch/PR for getting the relevant commits into main? As you can tell, I don't feel proficient enough in git to see what would be the best solution. |
|
I am not a git expert either. I tried making a merge request for your branch against master, but that gives a huge amount of changes, I think because the Personally, I would create patch from this PR, and apply it to master to create a new PR (so what you suggest above). @Jeffrey-Vervoort-KNMI, do you have a suggestion how to handle this? This is currently a branch of a branch, but the code is unrelated to that branch, and it would be better if it goes straight into main. |
|
Hm, I think the best is simply to start from scratch, i.e. create a new branch off main, add a single commit with the net change, and then a PR for that. Stay tuned ... |
|
Done! Forget this PR and use this one instead! |
No description provided.