Added/improved code comments

EURODEO · Feb 16, 2024 · ee43d52 · ee43d52 · github-actions · Feb 16, 2024
1 parent 76ee807
commit ee43d52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/datastore/datastore/dsimpl/getobservations.go b/datastore/datastore/dsimpl/getobservations.go
@@ -74,7 +74,8 @@ func getTemporalSpec(request *datastore.GetObsRequest) (common.TemporalSpec, err
 			// tspec.LatestMaxage)
 			return common.TemporalSpec{}, fmt.Errorf("latest_maxage unimplemented")
 		} else {
-			// by default don't consider any observation as too old
+			// by default disable filtering on maxage, i.e. don't consider any observation as too
+			// old
 			tspec.LatestMaxage = time.Duration(-1)
 		}
 	}

diff --git a/datastore/datastore/storagebackend/postgresql/getobservations.go b/datastore/datastore/storagebackend/postgresql/getobservations.go
@@ -437,7 +437,7 @@ func getObs(
 	oldestTime := time.Time{}
 	if !tspec.IntervalMode {
 		loTime, hiTime := common.GetValidTimeRange()
-		if tspec.LatestMaxage < 0 {
+		if tspec.LatestMaxage < 0 { // i.e. filtering on maxage is disabled
 			oldestTime = loTime
 		} else {
 			oldestTime = hiTime.Add(-tspec.LatestMaxage)
File	Stmts	Miss	Cover	Missing
\_\_init\_\_.py	0	0	100%
datastore_pb2.py	58	46	21%	24–69
datastore_pb2_grpc.py	43	23	47%	37–52, 85–87, 92–94, 99–101, 106–108, 112–136, 174, 191, 208, 225
dependencies.py	31	4	87%	23–24, 31, 38
grpc_getter.py	8	4	50%	12–16
locustfile.py	15	15	0%	1–31
main.py	22	3	86%	27, 37, 47
metadata_endpoints.py	19	4	79%	16, 33–66, 70
formatters
\_\_init\_\_.py	7	0	100%
covjson.py	46	1	98%	58
routers
\_\_init\_\_.py	0	0	100%
edr.py	71	11	85%	36–59, 109–110, 137–138
records.py	0	0	100%
TOTAL	320	111	65%