Skip to content

Commit

Permalink
Disable go vet as it requires the protoc files to be generated. This …
Browse files Browse the repository at this point in the history
…can be annoying in a pre-commit hook. In the pipeline we might want to have it after building and publishing the image.
  • Loading branch information
Jeffrey-Vervoort-KNMI committed Oct 23, 2023
1 parent 3291145 commit 823d9a9
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ jobs:
run: ./ci/go/go-fmt.sh
shell: bash

go-vet:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Run gofmt
run: ./ci/go/go-vet.sh
shell: bash
# go-vet:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
#
# - name: Run gofmt
# run: ./ci/go/go-vet.sh
# shell: bash

python-lint-black:
runs-on: ubuntu-latest
Expand Down
14 changes: 7 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ repos:
entry: ./ci/go/go-fmt.sh
language: script
pass_filenames: false
# go-vet ~ Finds subtle issues in Go where your code may not work as intended
- id: go-vet
name: go-vet
description: "Finds subtle issues in Go where your code may not work as intended."
entry: ./ci/go/go-vet.sh
language: script
pass_filenames: false
# # go-vet ~ Finds subtle issues in Go where your code may not work as intended
# - id: go-vet
# name: go-vet
# description: "Finds subtle issues in Go where your code may not work as intended."
# entry: ./ci/go/go-vet.sh
# language: script
# pass_filenames: false

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
Expand Down

0 comments on commit 823d9a9

Please sign in to comment.