Updating CMORization episode #313

gulcing · 2024-05-02T12:02:16Z

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.

Before you start

Read CONTRIBUTING.md.
Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

Give this pull request a descriptive title.
If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes {#270 #289 #314}

LisaBock

Thanks @gulcing for adding these information! This seems very useful.

…lTool_Tutorial into update_episode_cmorize

LisaBock · 2024-05-28T13:19:35Z

@gulcing :
I rerun all code which is in this episode and it works all fine for me.
Maybe we could have a look together on your error message...

LisaBock · 2024-05-28T13:23:09Z

Hi @rswamina , could you maybe have a look on this PR?

Strangely the recent updates from you in the basic episodes are shown here as well. I don't know why...

rswamina · 2024-05-29T12:18:41Z

_episodes/09-cmorization.md

@@ -123,6 +123,12 @@ run the CMORizer scripts:
 esmvaltool data format --config_file <path to config-user.yml>  <dataset-name>
 ```

+The options `--start` and `--end` can be added to command above to restrict the
+formatting of raw data to a time range. They will be ignored if a specific
+dataset does not support (i.e. because it is provided as a single file).


Suggested change: dataset does not support -> dataset does not support this option (i.e because all the data is provided as a single file).

rswamina · 2024-05-29T12:20:30Z

_episodes/09-cmorization.md

-... input_dir  = /home/peter/data/RAWOBS
-... output_dir = /home/peter/esmvaltool_output/data_formatting_20220726_140216
+... input_dir  = /work/bd0854/DATA/ESMValTool2/RAWOBS
+... output_dir = /scratch/b/b309059/esmvaltool_output/data_formatting_20240527_132448


It is not clear if b309059 is a user name. I suggest changing this to username and mentioing that this will be substituted by the individual's username (maybe at the start of the episode).

rswamina · 2024-05-29T12:23:04Z

_episodes/09-cmorization.md

 ~~~
 {: .error}

-If you look closely at the error messages, you can see that this error concerns
-the units of the coordinates. ESMValTool tries to fix them automatically,
+If you look closely at the error messages, you can see that these error concern


suggested change: that these error concern -> the reasons for these errors.

@LisaBock - I am not sure why example_output.txt was touched with this PR as it is not used in the CMORization episode. This is an older version of the file I think. Can you update this from the main repository before pushing?
I have suggseted some changes. If you are ok with them, let me know once when done and I will approve.

LisaBock · 2024-11-19T16:24:59Z

@rswamina - I realized today that we were already almost done with updating the cmorization episode. So I made some changes according to your review and updated the compatibility to v2.11.0. Should be fine now. If you agree, please merge.

rswamina · 2024-11-20T15:04:29Z

_episodes/09-cmorization.md

-...
-... Starting the CMORization Tool at time: 2022-07-26 14:02:16 UTC
+... Writing program log files to:
+/scratch/b/b309059/esmvaltool_output/data_formatting_20240527_132448/run/main_log.txt


Can all references to b309059 be changed to username so it is less confusing and consistent with other episodes?

rswamina

@LisaBock - Is it possible for me to review one final version of this document. Right now I see a plit screen with some old and newer changes. If you can make changes to alter the username and push teh changes, I will take another pass at reviewing.

rswamina · 2024-11-20T16:06:54Z

@LisaBock and @gulcing - can you add a link to the documentation for this tutorial. Maybe this page : https://docs.esmvaltool.org/en/latest/develop/dataset.html .

LisaBock · 2024-11-21T08:29:34Z

@LisaBock - Is it possible for me to review one final version of this document. Right now I see a plit screen with some old and newer changes. If you can make changes to alter the username and push teh changes, I will take another pass at reviewing.

@rswamina - The PR is ready now for a final review...

LisaBock · 2024-11-21T08:30:25Z

@LisaBock and @gulcing - can you add a link to the documentation for this tutorial. Maybe this page : https://docs.esmvaltool.org/en/latest/develop/dataset.html .

@rswamina - good idea! I will do so when the updated episode is merged.

rswamina · 2024-11-21T14:40:56Z

@LisaBock and @gulcing - can you add a link to the documentation for this tutorial. Maybe this page : https://docs.esmvaltool.org/en/latest/develop/dataset.html .

@rswamina - good idea! I will do so when the updated episode is merged.
@LisaBock - Are you going to add a link to the documentation page in this episode before I approve and merge or did you want to cerate a new PR for that?

LisaBock · 2024-11-22T07:37:51Z

@LisaBock and @gulcing - can you add a link to the documentation for this tutorial. Maybe this page : https://docs.esmvaltool.org/en/latest/develop/dataset.html .

@rswamina - good idea! I will do so when the updated episode is merged.
@LisaBock - Are you going to add a link to the documentation page in this episode before I approve and merge or did you want to cerate a new PR for that?

Ah, sorry @rswamina , I understood it wrong. I thought you want us to add a link in the documentation...
As there are already links in this episode to the documentation, could you please point me to the place where you are missing a link?

updated CMORization episode

b1da7a1

gulcing added feature Suggest a feature enhancement New feature or request labels May 2, 2024

gulcing requested a review from LisaBock May 2, 2024 12:02

LisaBock approved these changes May 16, 2024

View reviewed changes

LisaBock added 4 commits May 27, 2024 15:33

Merge branch 'update_episode_cmorize' of github.com:ESMValGroup/ESMVa…

1a14aba

…lTool_Tutorial into update_episode_cmorize

small updates

5be74d5

update version

1bc58f6

fix line length

d4c9e77

LisaBock requested a review from rswamina May 28, 2024 13:19

rswamina reviewed May 29, 2024

View reviewed changes

LisaBock added 3 commits November 19, 2024 16:48

Merge remote-tracking branch 'origin/main' into update_episode_cmorize

37aa227

changes regarding the review

0ef9a3a

change compatibility

e6f6eec

rswamina reviewed Nov 20, 2024

View reviewed changes

rswamina requested changes Nov 20, 2024

View reviewed changes

LisaBock added 2 commits November 21, 2024 09:21

Merge remote-tracking branch 'origin/main' into update_episode_cmorize

3c9c652

insert 'username'

d6ffa26

rswamina approved these changes Nov 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating CMORization episode #313

Updating CMORization episode #313

gulcing commented May 2, 2024 •

edited by LisaBock

Loading

LisaBock left a comment

LisaBock commented May 28, 2024

LisaBock commented May 28, 2024

rswamina May 29, 2024

rswamina May 29, 2024

rswamina May 29, 2024

rswamina May 29, 2024

LisaBock commented Nov 19, 2024

rswamina Nov 20, 2024

rswamina left a comment

rswamina commented Nov 20, 2024

LisaBock commented Nov 21, 2024

LisaBock commented Nov 21, 2024

rswamina commented Nov 21, 2024

LisaBock commented Nov 22, 2024

Updating CMORization episode #313

Are you sure you want to change the base?

Updating CMORization episode #313

Conversation

gulcing commented May 2, 2024 • edited by LisaBock Loading

Pull Request checklist

Before you start

Tasks

LisaBock left a comment

Choose a reason for hiding this comment

LisaBock commented May 28, 2024

LisaBock commented May 28, 2024

rswamina May 29, 2024

Choose a reason for hiding this comment

rswamina May 29, 2024

Choose a reason for hiding this comment

rswamina May 29, 2024

Choose a reason for hiding this comment

rswamina May 29, 2024

Choose a reason for hiding this comment

LisaBock commented Nov 19, 2024

rswamina Nov 20, 2024

Choose a reason for hiding this comment

rswamina left a comment

Choose a reason for hiding this comment

rswamina commented Nov 20, 2024

LisaBock commented Nov 21, 2024

LisaBock commented Nov 21, 2024

rswamina commented Nov 21, 2024

LisaBock commented Nov 22, 2024

gulcing commented May 2, 2024 •

edited by LisaBock

Loading