Updates to recipe_seaborn.yml and seaborn diagnostic #3808
Conversation
- Modified the seaborn_diag.py for jointplot - Modified the recipe_seaborn.yml to plot the figures - Added Pacal, Aytac to config-references.yml
There was a problem hiding this comment.
Thank you for implementing this 👍 I have a couple of comments on the code.
Also, I wonder if it makes sense to put this into the recipes/cloud directory as some kind of recipe_clouds_scatterplot? @axel-lauer, what do you think?
| if plot_func_str in ['jointplot']: | ||
| data_frame = data_frame.reset_index() | ||
|
|
There was a problem hiding this comment.
Have you tried running the diagnostic with the option reset_index: true?
| @@ -171,7 +174,10 @@ def _create_plot( | |||
| getattr(plot_obj, func_name)(func_args) | |||
| if cfg['suptitle'] is not None: | |||
| logger.debug("Setting `suptitle='%s'`", cfg['suptitle']) | |||
| plt.suptitle(cfg['suptitle'], y=1.05) | |||
| if plot_func_str in ['jointplot']: | |||
| plt.suptitle(cfg['suptitle'].format(data_frame["shape_id"].unique()[0]), y=1.05) | |||
There was a problem hiding this comment.
This will cause the diagnostic to fail if no shape_id is present. Is this change necessary because you created a multi-panel plot (as far as I understand, this is not possible with jointplot)? If you need such a change, it would be better to hardcode the format string into the recipe Like Plot of {shape_id} and then let the diagnostic fill this. This will be much more general.
| @@ -443,6 +449,11 @@ def _set_legend_title(plot_obj, legend_title: str) -> None: | |||
| legend = plot_obj.get_legend() | |||
| elif hasattr(plot_obj, 'legend'): # FacetGrid, PairGrid | |||
| legend = plot_obj.legend | |||
| elif isinstance(plot_obj, sns.axisgrid.JointGrid): # JointGrid workaround | |||
There was a problem hiding this comment.
| elif isinstance(plot_obj, sns.axisgrid.JointGrid): # JointGrid workaround | |
| elif isinstance(plot_obj, sns.axisgrid.JointGrid): # JointGrid |
If JointGrid also need a special treatment I wouldn't call this "workaround" 😉
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: