Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with the radiation budget recipe #3653

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mo-gill
Copy link
Contributor

@mo-gill mo-gill commented Jun 14, 2024

Description


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@mo-gill mo-gill requested a review from ehogan June 14, 2024 10:44
@mo-gill mo-gill self-assigned this Jun 14, 2024
@mo-gill mo-gill changed the title First MO copyright additions and update R pre-commit Fix issues with the radiation budget recipe Jun 14, 2024
@mo-gill
Copy link
Contributor Author

mo-gill commented Jun 14, 2024

Updated the rev of R as the pre-commit wasn't working in commit d7dec58

@mo-gill mo-gill marked this pull request as ready for review June 17, 2024 10:22
@valeriupredoi
Copy link
Contributor

OK the RTD import issue is reproducible:

(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list psy
# packages in environment at /home/valeriu/miniconda3/envs/esmvaltool:
#
# Name                    Version                   Build  Channel
psy-maps                  1.5.0           py311h38be061_1    conda-forge
psy-reg                   1.4.0           py311h38be061_3    conda-forge
psy-simple                1.5.0           py311h38be061_1    conda-forge
psyplot                   1.5.0           py311h38be061_1    conda-forge
(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ python esmvaltool/diag_scripts/psyplot_diag.py
WARNING:psyplot.config.rcsetup:Failed to import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')!
WARNING:psyplot:Could not import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')
Traceback (most recent call last):
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psyplot/__init__.py", line 132, in get_versions
    mod = ep.load()
          ^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/importlib_metadata/__init__.py", line 184, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psy_reg/plugin.py", line 36, in <module>
    from psyplot.compat.pycompat import map, filter
ModuleNotFoundError: No module named 'psyplot.compat'
usage: psyplot_diag.py [-h] [-f] [-i] [-n] [-l {debug,info,warning,error}] filename
psyplot_diag.py: error: the following arguments are required: filename

@schlunma seen this before? If not, I'll ping Philipp about it 🍺

@valeriupredoi
Copy link
Contributor

@schlunma nay bother, we have it all in #3638

@bouweandela
Copy link
Member

note that the documentation build is failing because of this warning, not because of linked issue.

/home/docs/checkouts/readthedocs.org/user_builds/esmvaltool/checkouts/3653/doc/sphinx/source/gallery.rst:482: WARNING: undefined label: 'c'

@valeriupredoi
Copy link
Contributor

well how is that possible since I just merged main here?

@valeriupredoi
Copy link
Contributor

at any rate - the problem with psy-reg is a bit more far-reaching than just the docs, that actual import psyplot.project as psy is failing, so the diagnostic itself is unusable

@bouweandela
Copy link
Member

well how is that possible since I just merged main here?

The issue is introduced in this pull request. Maybe one of those copyright (C)s is getting interpreted as a rst label?

@valeriupredoi
Copy link
Contributor

well how is that possible since I just merged main here?

The issue is introduced in this pull request. Maybe one of those copyright (C)s is getting interpreted as a rst label?

ah gotcha, thanks, bud! @mo-gill please fix that then, cheers 🍺 Well this lead to another, I fixed the psy-reg plugin issue in #3687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues with the radiation budget recipe
3 participants