-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fix_file
to return Cube
and CubeList
objects
#2579
Draft
schlunma
wants to merge
35
commits into
main
Choose a base branch
from
better_fix_file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable lock sharing between ncdata and Iris Suppress load warnings Restore lat/lon coord units after load All fixes in fix_file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
+ Coverage 94.66% 94.69% +0.02%
==========================================
Files 251 251
Lines 14287 14334 +47
==========================================
+ Hits 13525 13573 +48
+ Misses 762 761 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if a file cannot be properly read with Iris, we use
fix_file
to create a copy of that file and modify it usingnetCDF4.Dataset
(example). This is very inefficient and slow.A much better way to deal with this is to read the file with ncdata or xarray and then use ncdata to convert that object to an Iris object. However, for this to work, we need to allow
fix_file
to return Iris objects (instead of paths) andload
to read Iris objects (instead of paths). This PR does that.It also provides a convenience function
dataset_to_iris
that allows to convert an xarray or ncdata object to an Iris object very similar to ourload
function.Closes #2129
Related to #674
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: