BLD: Silence all warnings in SciPy #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UCRT64 failure shouldn't be related to this PR (since none of the sources have changed, and AFAIK the CI run doesn't even use |
CI test failures like this are due to GitHub, and pass on re-running (as I'm now trying) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought about silencing these only at the SciPy end, but on whole I think it makes sense to be explicit here, since not having a clean build (w.r.t warnings) is a project level issue.
This is the last (mandatory) PR for the SciPy update. Warnings fixes can still be ported from #1987 later without blocking the SciPy update.
Please consider merging as soon as the SciPy CI is green : scipy/scipy#21565
Then the only thing left is over at SciPy (I'll just update the fork) and we'll finally have an up-to-date HiGHS!