Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor changes #1908

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Some minor changes #1908

merged 11 commits into from
Sep 4, 2024

Conversation

fwesselm
Copy link
Contributor

@fwesselm fwesselm commented Sep 4, 2024

  • Use std::array instead of C arrays
  • Character strings produced by snprintf and vsnprintf are null-terminated, so no need to check
  • Fix typo in src/parallel/HighsSplitDeque.h
  • Testing on 400+ MIP instances revealed no issues

@jajhall jajhall self-requested a review September 4, 2024 11:58
jajhall
jajhall approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with me. I'll merge into a new branch so that I can fix the formatting failures

@fwesselm
Copy link
Contributor Author

fwesselm commented Sep 4, 2024

Maybe restarting test-clang-format would help, it looks like it did not run.

@jajhall jajhall changed the base branch from latest to fix-1908 September 4, 2024 12:29
@jajhall jajhall merged commit 8f99e6f into ERGO-Code:fix-1908 Sep 4, 2024
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajhall jajhall jajhall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwesselm @jajhall