Always set $STORAGE and $JOB_STORAGE in bot/test.sh
#837
Conversation
…d; fall back to $PWD otherwise
|
Instance
|
|
Instance
|
|
Instance
|
| @@ -103,34 +103,34 @@ fi | |||
| RESUME_DIR=$(grep 'Using .* as tmp directory' slurm-${SLURM_JOBID}.out | head -1 | awk '{print $2}') | |||
|
|
|||
| if [[ -z ${RESUME_DIR} ]]; then | |||
There was a problem hiding this comment.
I'm now doing this in either case, so both when $RESUME_DIR is set and when it's not set. Or can we point $JOB_STORAGE to $RESUME_DIR or something in case $RESUME_DIR is set?
There was a problem hiding this comment.
OK, this should work. If we cannot find the temp storage directory from a previous run ($RESUME_DIR being empty), then we check if we can find a tarball of that run. If not, we exit with an error. If we find it we create the temporary storage.
This is now always available to set $SINGULARITY_TMPDIR.
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
Even when resuming from a previous directory/tarball,
$STORAGEand$JOB_STORAGEare not set, so I think we should always do this. For that reason, I moved them out of the if statement.Also, this sets
$SINGULARITY_TMPDIRto a subdir of$JOB_STORAGE, similar to the change made in #836.