-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accelerator detection to Lmod version of EESSI initialisation #781
Conversation
Instance
|
Instance
|
@boegel You are probably best placed to review this. I've added a lot of new CI which caught a few problems (in particular unloading the module did not unset a range of environment variables). There is also a check which compares the environment available via the module to that given by the init script. I've also added a debug mode which can be used to print additional information. |
bot: build repo:eessi.io-2023.06-software arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the code and it works for... 99%. On our system, LMOD_PACKAGE_PATH
is set. After loading & unloading the EESSI
module, it is unset. So... not exactly the same environment as before :\
I don't know if there is an easy fix. If not, I'm happy to merge this as is - it's definitely a big improvement over what we had.
If we fix it, we should probably also put something like this in the CI tests (i.e. set LMOD_PACKAGE_PATH
, load & unload EESSI, and do the env comparison before and after loading/unloading)
Switched to |
I'm reluctant to put |
bot: build repo:eessi.io-2023.06-software arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
Couldn't you copy (or symlink) that file to a new location, then point |
I'm not against it really but it feels like a potential CI rabbit hole since it does affect Lmod behaviour. If someone is keen enough, that could be done in a follow-up PR. |
Tried again. these were the only differences:
Not sure what exactly this _LMOD_STACK thing is, but I'm ok with it. |
Label |
PR merged! Moved |
PR merged! Moved |
PR merged! Moved |
Requires