-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak scripts to support building for dev.eessi.io
repository
#771
tweak scripts to support building for dev.eessi.io
repository
#771
Conversation
I was checking that it is *not* set 🤦
We need it for the compat layer
Instance
|
Instance
|
Instance
|
To be able to also pick up on overriden compat layers
Moved it to minimal_eessi_env
We're already in the right path!
${TOPDIR}/install_scripts.sh --prefix ${EESSI_PREFIX} | ||
|
||
# Only run install_scripts.sh if not dev.eessi.io for security | ||
if [[ "${EESSI_CVMFS_REPO}" != /cvmfs/dev.eessi.io ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this makes sense, but it will cause fallout below where the install_cuda_host_injections.sh
script is called.
OK to ignore for now since it's only relevant when we're building CUDA software in dev.eessi.io
), but we'll probably need to have a construct like this:
if [[ "${EESSI_CVMFS_REPO}" == /cvmfs/dev.eessi.io ]]; then
SCRIPTS_DIR=/cvmfs/software.eessi.io
else
SCRIPTS_DIR=${EESSI_PREFIX}
# copy latest version of scripts before using them (don't use the ones already deployed in EESSI)
${TOPDIR}/install_scripts.sh --prefix ${EESSI_PREFIX}
fi
and then use $SCRIPTS_DIR
when calling install_cuda_host_injections.sh
& co below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a follow up PR
Co-authored-by: Kenneth Hoste <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR merged! Moved |
PR merged! Moved |
PR merged! Moved |
No description provided.