Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bot/bot-check.sh script correctly pick up builds for accelerators #726

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Sep 19, 2024

Fixes EESSI/eessi-bot-software-layer#286 (more or less). The problem here was that the script was only checking for new installations in the CPU prefix, and it interpreted everything else (including stuff in the accelerator prefix) to be "other files". The latter would get printed in full, leading to a very large Github comment. This is now fixed by appending accel/${accelerator} to ${prefix} for accelerator builds. Note that this only works for non-mixed builds (i.e. either CPU-only builds or GPU-only builds), but I think we decided that we would not allow this, at least not for now, to prevent that things get mixed up.

Copy link

eessi-bot bot commented Sep 19, 2024

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

Instance boegel-bot-deucalion is configured to build for:

  • architectures: aarch64/a64fx
  • repositories: eessi.io-2023.06-software

Copy link

eessi-bot bot commented Sep 19, 2024

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software, eessi.io-2023.06-compat

@bedroge bedroge changed the title adjust the prefix variable for accelerator builds Make the bot/bot-check.sh script correctly pick up builds for accelerators Sep 19, 2024
@bedroge
Copy link
Collaborator Author

bedroge commented Sep 20, 2024

Successfully tested in #728 (comment).

@boegel boegel merged commit c006897 into EESSI:2023.06-software.eessi.io Sep 23, 2024
35 checks passed
Copy link

eessi-bot bot commented Sep 23, 2024

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2024.09.23

1 similar comment
Copy link

eessi-bot bot commented Sep 23, 2024

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2024.09.23

@bedroge bedroge deleted the fix_tarball_overview_for_accelerators branch September 23, 2024 07:16
@boegel boegel added 2023.06-software.eessi.io 2023.06 version of software.eessi.io accel:nvidia labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io accel:nvidia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot fails to report back of the body contains too many characters
2 participants