Make the bot/bot-check.sh
script correctly pick up builds for accelerators
#726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EESSI/eessi-bot-software-layer#286 (more or less). The problem here was that the script was only checking for new installations in the CPU prefix, and it interpreted everything else (including stuff in the accelerator prefix) to be "other files". The latter would get printed in full, leading to a very large Github comment. This is now fixed by appending
accel/${accelerator}
to${prefix}
for accelerator builds. Note that this only works for non-mixed builds (i.e. either CPU-only builds or GPU-only builds), but I think we decided that we would not allow this, at least not for now, to prevent that things get mixed up.