Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only correct the Zen4 software subdirectory if it has not been overridden #573

Merged
merged 2 commits into from
May 16, 2024

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 15, 2024

Forcing Zen3 over Zen4 was not respecting $EESSI_SOFTWARE_SUBDIR_OVERRIDE

Copy link

eessi-bot bot commented May 15, 2024

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

Copy link

eessi-bot bot commented May 15, 2024

Instance eessi-bot-mc-azure is configured to build:

  • arch x86_64/amd/zen4 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen4 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen4 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen4 for repo eessi.io-2023.06-software

@ocaisa ocaisa changed the title Only correct the Zen4 software subdirectory if it has not been overri… Only correct the Zen4 software subdirectory if it has not been overridden May 15, 2024
@ocaisa
Copy link
Member Author

ocaisa commented May 15, 2024

Works as intended:

[ocaisa@x86-64-amd-zen4-node1 software-layer]$ source init/bash 
Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!
archdetect says x86_64/amd/zen4
Sticking to x86_64/amd/zen3 for now, since optimized installations for AMD Genoa (Zen4) are a work in progress, see https://gitlab.com/eessi/support/-/issues/37 for more information
...
{EESSI 2023.06} [ocaisa@x86-64-amd-zen4-node1 software-layer]$ export EESSI_SOFTWARE_SUBDIR_OVERRIDE=x86_64/amd/zen4
{EESSI 2023.06} [ocaisa@x86-64-amd-zen4-node1 software-layer]$ source init/bash 
Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!
archdetect says x86_64/amd/zen4
Using x86_64/amd/zen4 as software subdirectory.
...

Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Contributor

boegel commented May 15, 2024

Tests are not happy?

@ocaisa
Copy link
Member Author

ocaisa commented May 15, 2024

It's easybuilders/easybuild-easyconfigs#20501 , tricky one to decide what to do about it

@boegel
Copy link
Contributor

boegel commented May 15, 2024

It's easybuilders/easybuild-easyconfigs#20501 , tricky one to decide what to do about it

Filter out PSM2 in our parse hook (at least in short term)?

@ocaisa
Copy link
Member Author

ocaisa commented May 15, 2024

Solution in #576

@boegel
Copy link
Contributor

boegel commented May 16, 2024

@ocaisa #576 merged, so this just needs a kick?

@ocaisa
Copy link
Member Author

ocaisa commented May 16, 2024

@boegel all the open PRs need a sync with the default branch due to the change in the EasyBuild configuration, starting on it now

@ocaisa
Copy link
Member Author

ocaisa commented May 16, 2024

bot: build repo:eessi.io-2023.06-software arch:x86_64/generic

Copy link

eessi-bot bot commented May 16, 2024

Updates by the bot instance eessi-bot-mc-aws (click for details)

Copy link

eessi-bot bot commented May 16, 2024

Updates by the bot instance eessi-bot-mc-azure (click for details)
  • received bot command build repo:eessi.io-2023.06-software arch:x86_64/generic from ocaisa

    • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/generic
  • handling command build repository:eessi.io-2023.06-software architecture:x86_64/generic resulted in:

    • no jobs were submitted

Copy link

eessi-bot bot commented May 16, 2024

New job on instance eessi-bot-mc-aws for architecture x86_64-generic for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.05/pr_573/10866

date job status comment
May 16 10:08:16 UTC 2024 submitted job id 10866 awaits release by job manager
May 16 10:08:22 UTC 2024 released job awaits launch by Slurm scheduler
May 16 10:09:24 UTC 2024 running job 10866 is running
May 16 10:14:29 UTC 2024 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-10866.out
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-generic-1715854112.tar.gzsize: 0 MiB (1892 bytes)
entries: 1
modules under 2023.06/software/linux/x86_64/generic/modules/all
no module files in tarball
software under 2023.06/software/linux/x86_64/generic/software
no software packages in tarball
other under 2023.06/software/linux/x86_64/generic
2023.06/init/eessi_environment_variables
May 16 10:14:29 UTC 2024 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 10/10 test case(s) from 10 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-10866.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
May 16 10:53:07 UTC 2024 uploaded transfer of eessi-2023.06-software-linux-x86_64-generic-1715854112.tar.gz to S3 bucket succeeded

@ocaisa ocaisa added the ready-to-deploy Mark a PR as ready to deploy label May 16, 2024
@ocaisa
Copy link
Member Author

ocaisa commented May 16, 2024

@boegel This is ready to go now

@boegel boegel merged commit 158ad00 into 2023.06-software.eessi.io May 16, 2024
70 checks passed
@ocaisa ocaisa added bot:deploy Ask bot to deploy missing software installations to EESSI and removed ready-to-deploy Mark a PR as ready to deploy labels May 16, 2024
@boegel
Copy link
Contributor

boegel commented May 16, 2024

Sorry for overlooking the deployment part... I saw a green light by CI, so I went for it :)

@bedroge bedroge deleted the ocaisa-patch-2 branch May 24, 2024 09:30
@boegel boegel added the 2023.06-software.eessi.io 2023.06 version of software.eessi.io label Jun 6, 2024
@bedroge bedroge added the zen4 label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io bot:deploy Ask bot to deploy missing software installations to EESSI zen4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants