-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run OSU test for now in test step. #571
Only run OSU test for now in test step. #571
Conversation
… this would take too long otherwise. In the (near) future, we should make some mapping to determine which tests to run for which software installations
Instance
|
Instance
|
bot: build repo:eessi.io-2023.06-software arch:x86_64/intel/skylake_avx512 |
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
Test step from the SLURM log:
That's exactly what I intended it to look like. It's also much faster now (30s), which is good for a default test step. Maybe in the long run we should be able to tell the bot to test, or not to test. That way, if we are still debugging builds, we don't have to run the test step (yet). |
Something is going wrong, I see a CUDA and PSM2 as missing installations |
PSM2 is coming from easybuilders/easybuild-easyconfigs#20501 which has a build dependency on CUDA (https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/p/PSM2/PSM2-12.0.1-GCCcore-12.2.0.eb#L26) |
@casparvl This now requires a sync with the default branch for CI to pass |
I'm not convinced we should go ahead and merge this, seems like something we'll easily forget to revert later, and the time needed to run the test suite currently isn't limiting at all imho... |
No longer needed, we now have test selection possibilities in #673 |
As the test suite is growing, the test step would start taking longer and longer. This is particularly annoying if you want to do small tweaks during a build.
In the (near) future, we should make some mapping to determine which tests to run for which software installations. E.g. if your tarball contains a new TensorFlow module, you probably want to run the TensorFlow test (
-n TensorFlow
). If your tarball contains OpenMPI, you probably want to runOSU
and maybe one MPI-based application (i.e.-n OSU -n GROMACS.*foss
for example).