Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tarball content type check in ingestion script #186

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Apr 2, 2024

This check caused failures for ingesting init tarballs built with the bot (which names the tarballs like eessi-2023.06-software-<date>.tar.gz, and the check would fail because of the software part in the filename) in EESSI/software-layer#524. The check is a bit useless anyway, so I've disabled it, and also disabled the tests. The code is still there in case we do want to use it again / in a slightly different way.

$ ./test-ingest-tarball.sh 
ERROR: /cvmfs/software.eessi.io/versions/2000.01 does not point to an existing directory!
Ran 23 tests, 23 succeeded, 0 failed.

(the error is actually due to another change in the ingestion script)

scripts/ingest-tarball.sh Outdated Show resolved Hide resolved
scripts/ingest-tarball.sh Show resolved Hide resolved
@bedroge
Copy link
Collaborator Author

bedroge commented Apr 2, 2024

Also made a small fix/improvement to the test script, and it no longer prints an error (which was shown because it cannot actually do the Lmod cache updates, it's now just being ignored):

$ ./test-ingest-tarball.sh 
Ran 23 tests, 23 succeeded, 0 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants