Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention PR url in body of staging PR #170

Merged
merged 1 commit into from
Jan 2, 2024
Merged

mention PR url in body of staging PR #170

merged 1 commit into from
Jan 2, 2024

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Jan 2, 2024

@bedroge Let's stop adding comments mentioning the PR URL...

Untested, so we need to keep an eye out after this is deployed, but should be easy to review.

@boegel boegel requested a review from bedroge January 2, 2024 18:22
Copy link
Collaborator

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful :-)

Tested the lines for retrieving the repo and pr_id with an older metadata file, and it worked fine.

@bedroge bedroge merged commit dadd220 into EESSI:main Jan 2, 2024
20 checks passed
@bedroge
Copy link
Collaborator

bedroge commented Jan 2, 2024

This has been deployed to the Stratum 0 as well, so the next PR for a new tarball should include the PR URL.

@boegel boegel deleted the pr_url branch January 2, 2024 19:19
@boegel
Copy link
Contributor Author

boegel commented Jan 3, 2024

works like a charm, see https://github.com/EESSI/staging/pull/731 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants