handle closed PRs too #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot log[20240820-T09:58:09] [handle_pull_request_event]: Handling PR action 'closed' for PR #48...
[20240820-T09:58:09] [handle_pull_request_closed_event]: PR 48: PR got merged (json value: True)
[20240820-T09:58:09] [handle_pull_request_closed_event]: PR 48: determining directories to be moved to trash bin
[20240820-T09:58:09] [handle_pull_request_closed_event]: PR 48: moving directories to trash bin /scratch/f115372/bot_shared_direct
ory/trash_bin/Neves-Bot/software-layer/2024.08.20
[20240820-T09:58:17] [handle_pull_request_closed_event]: PR 48: moved directories to trash bin /scratch/f115372/bot_shared_directo
ry/trash_bin/Neves-Bot/software-layer/2024.08.20 (took 7 seconds)
[20240820-T09:58:20] [handle_issue_comment_event]: Comment in https://api.github.com/repos/Neves-Bot/software-layer/issues/48 (own
ed by @neves-p-bot[bot]) created by @neves-p-bot[bot]
[20240820-T09:58:20] [handle_issue_comment_event]: comment action 'created' is handled
[20240820-T09:58:20] [handle_issue_comment_event]: comment does not contain a bot comment; not processing it further
Bot log[20240820-T10:18:21] [handle_pull_request_event]: Handling PR action 'closed' for PR #49...
[20240820-T10:18:21] [handle_pull_request_closed_event]: PR 49: PR got closed (json value: False)
[20240820-T10:18:21] [handle_pull_request_closed_event]: PR 49: determining directories to be moved to trash bin
[20240820-T10:18:21] [handle_pull_request_closed_event]: PR 49: moving directories to trash bin /scratch/f115372/bot_shared_directory/trash_bin/Neves-Bot/software-layer/2024.08.20
[20240820-T10:18:28] [handle_pull_request_closed_event]: PR 49: moved directories to trash bin /scratch/f115372/bot_shared_directory/trash_bin/Neves-Bot/software-layer/2024.08.20 (took 7 seconds)
[20240820-T10:18:31] [handle_issue_comment_event]: Comment in https://api.github.com/repos/Neves-Bot/software-layer/issues/49 (owned by @neves-p-bot[bot]) created by @neves-p-bot[bot]
[20240820-T10:18:31] [handle_issue_comment_event]: comment action 'created' is handled
[20240820-T10:18:31] [handle_issue_comment_event]: comment does not contain a bot comment; not processing it further
Looks good! |
Neves-P
requested changes
Aug 20, 2024
Co-authored-by: Pedro Santos Neves <[email protected]>
Neves-P
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the clean up code such that data of PRs is moved to a trash bin directory also in case the PR was closed.
WIP because it's not been tested yet.Has been tested by @Neves-P. Thanks!