add setting to give all jobs a unique name #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Jun 24, 2024
tasks/build.py
Outdated
| @@ -654,6 +662,7 @@ def submit_job(job, cfg): | |||
| build_env_cfg[config.BUILDENV_SETTING_SLURM_PARAMS], | |||
| time_limit, | |||
| job.slurm_opts, | |||
| f"--job-name='{job_name}'", | |||
There was a problem hiding this comment.
Also here, only use --job-name is the job_name is not None?
boegel
requested changes
Aug 6, 2024
tasks/build.py
Outdated
| @@ -67,6 +67,10 @@ def get_build_env_cfg(cfg): | |||
|
|
|||
| buildenv = cfg[config.SECTION_BUILDENV] | |||
|
|
|||
| job_name = buildenv.get(config.BUILDENV_SETTING_JOB_NAME) | |||
| log(f"{fn}(): job_name '{job_name}'") | |||
| config_data = {config.BUILDENV_SETTING_JOB_NAME: job_name} | |||
There was a problem hiding this comment.
This won't work, since config_data is overwritten below?
You should change the line 76 below to:
config_data[config.BUILDENV_SETTING_JOBS_BASE_DIR] = jobs_base_dirThis also shows this wasn't (re)tested?
There was a problem hiding this comment.
Fixed. Tested. Should work. 😬
boegel
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now all jobs are named after the job script. This PR adds a new configuration setting
job_namethat is used as the job's name. This is then also used by the job manager to list all jobs (with that name). Thus it is possible to have multiple bot instances running at the same cluster where each bot instance uses a different job name. Hence, each bot instance is able to only handle its "own" jobs. We can use this to run a separate bot instance, for example, for bot development and testing.