script to clean up tarballs of jobs given a PR number #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Oct 2, 2023
cleanup_pr.sh
Outdated
| # restore potentially parsed filename(s) into $* | ||
| set -- "${POSITIONAL_ARGS[@]}" | ||
|
|
||
| if [[ $# -lt 1 ]]; then |
There was a problem hiding this comment.
Don't we want exactly 1 PR number here?
If so, use $# -ne 1, and adjust the error message, like "ERROR: Exactly one PR number should be provided".
cleanup_pr.sh
Outdated
| if ${dry_run} = true ; then | ||
| echo "DRY_RUN: rm '$f' ($(ls -lh $f | awk '{print $5}'))" | ||
| else | ||
| rm $f |
There was a problem hiding this comment.
maybe also emit a message when removing a file?
echo "Removing $f..."`
|
@trz42 Next step (maybe in follow-up PR) could be to run this script every time a PR is closed/merged? |
Good idea. We could implement this as follows:
|
|
@trz42 Should we move the script into the |
boegel
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To delete all major tarballs (temporary storage and build artefacts such as software installations) of PR
NUMBER, simply run withfrom bot directory that contains
app.cfg(used to determine base directory for jobs, e.g., settingjobs_base_dir).-Dor--dry-runto check what the script would do.-b DIRor--jobs-base-dir DIRwhereDIRpoints to the base directory of jobs.