Skip to content

Commit

Permalink
Merge pull request #175 from jonas-lq/issue#173
Browse files Browse the repository at this point in the history
Fixed typos from PR170
  • Loading branch information
boegel authored Apr 11, 2023
2 parents 9f4ff7a + cca788f commit 28cb285
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions app.cfg.example
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,13 @@ poll_interval = 60
# full path to the command for manipulating existing jobs
scontrol_command = /usr/bin/scontrol

# variable 'comment' under 'submitted_job_comments' should not be changed as there are regular expression patterns matching it
# variable 'initial_comment' under 'submitted_job_comments' should not be changed as the bot's code uses regular expression pattern to identify a matching comment
[submitted_job_comments]
initial_comment = New job on instance `{app_name}` for architecture `{arch_name}` for repository `{repo_id}` in job dir `{symlink}`
awaits_release = job id `{job_id}` awaits release by job manager

[new_job_comments]
awaits_lauch = job awaits launch by Slurm scheduler
awaits_launch = job awaits launch by Slurm scheduler

[running_job_comments]
running_job = job `{job_id}` is running
Expand Down
6 changes: 3 additions & 3 deletions eessi_bot_job_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

from pyghee.utils import log, error

AWAITS_LAUCH = "awaits_lauch"
AWAITS_LAUNCH = "awaits_launch"
FAILURE = "failure"
FINISHED_JOB_COMMENTS = "finished_job_comments"
NEW_JOB_COMMENTS = "new_job_comments"
Expand All @@ -58,7 +58,7 @@
SUCCESS = "success"

REQUIRED_CONFIG = {
NEW_JOB_COMMENTS: [AWAITS_LAUCH],
NEW_JOB_COMMENTS: [AWAITS_LAUNCH],
RUNNING_JOB_COMMENTS: [RUNNING_JOB],
FINISHED_JOB_COMMENTS: [SUCCESS, FAILURE, NO_SLURM_OUT, SLURM_OUT, MISSING_MODULES,
NO_TARBALL_MESSAGE, NO_MATCHING_TARBALL, MULTIPLE_TARBALLS]
Expand Down Expand Up @@ -315,7 +315,7 @@ def process_new_job(self, new_job):
new_job_comments_cfg = config.read_config()[NEW_JOB_COMMENTS]
dt = datetime.now(timezone.utc)
update = "\n|%s|released|" % dt.strftime("%b %d %X %Z %Y")
update += f"{new_job_comments_cfg[AWAITS_LAUCH]}|"
update += f"{new_job_comments_cfg[AWAITS_LAUNCH]}|"
update_comment(new_job["comment_id"], pr, update)
else:
log(
Expand Down

0 comments on commit 28cb285

Please sign in to comment.