-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer adding_software
over contributing_sw
in docs URL + fix broken URLs using auto-redirect
#122
Conversation
…ding_software broken URL using auto-redirect
adding_software
over contributing_sw
in docs URL + fix /adding_software
broken URL using auto-redirectadding_software
over contributing_sw
in docs URL + fix broken URLs using auto-redirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two general comments.
We had a prior discussion on whether to use 'adding' or 'contributing'. I used contributing because it makes clear that it is something anyone can do. You also use 'contributing to EasyBuild' in the EasyBuild docs when you talk about EasyConfigs that people contribute. A page on 'adding software' to me creates less clear expectations to the reader - it could also just describe how we add software, or how software gets added by others. Hence my preference for 'contributing': it really makes clear someone can do it themselves. Note that Thomas also brought up 'adding' as an alternative, see her #117 (comment)
If both of you really feel that 'adding' is better, I'm ok in changing it.
Regarding the redirect links: I'm completely fine with giving it a try, but in one of the meetings (support meeting? Can't remember, maybe it was just private conversation with Thomas) we also concluded that keeping all links indefinitely active would be a nightmare. I don't think anyone will be too 'lost' that they can't figure out to go to the root of the page and start their search from there.
Especially since we are a project in its early phase, I imagine the docs might change quite a bit a few more times. Having to create redirects for all of those might make that mkdocs.yml a bit messy.
Anyway, I'm not against it, so let's keep it in this PR. Regarding the 'contributing' vs 'adding' discussion: please give it another thought which of the two headersyou think helps people to find the right page for what they want to do. If you still feel that's 'adding', I'm ok with that too. In that case: feel free to even merge this PR yourself - apart from making sure you give it another thought, I have no further objections :)
@casparvl W.r.t. redirects: that's basically "do once and forget" in Being a project under heavy development is not a good excuse for broken URLs in docs imho, since we're literally talking about adding a single line in a YAML file per changed URL whenever we change our mind w.r.t. structure of the documentation (which is fine, docs should evolve over time). Not wanting to do make that small effort and let people hunt for the info they're looking for in the restructured docs is a bit lame imho (I certainly get very annoyed personally when I hit a 404 page for a URL that I know used to work). There's also no real negative side to keep a (long) list of redirecting URLs, other than perhaps a longer W.r.t. adding vs contributing: I guess you could argue both ways. It's more about consistency for me: the current URL uses That said, I prefer "adding" over "contributing". Mostly because it's easier to understand (and contributing sounds like more work perhaps for someone new to the concept of EESSI). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fair enough, happy with @boegel 's reply. Merging!
Summary of changes:
docs/contributing_sw/*
todocs/adding_software/*
: no need for using cryptic things like 'sw' to shorten URLs, and we consistently use "adding software" throughout this part of the docs;/adding_software/overview
page rather than leaving a TODO there;