Merging Playlist Manager Feature #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented getting and locally cache/storing a playlist's tracks' songIDs and those tracks' audio features as well. Created three files so far, 2 in the services folder for handling API requests and response structure, and 1 in the components folder handling getting the playlist ID of an owned playlist on a user's screen.
Pulling down changes for testing
Preset creation logic, and playlist dynamic reordering logic complete and tested. Delay issue fixed. Only issue left pertains to UI of the feature and permanently effecting the Spotify App instead of for just one instance on load.
Modified code to include mutation observers for various aspects of the page to determine and implement permanent UI injections. Discuss style with the team, made some changes to meet overall agreeance.
Fixed some TypeScript errors (that were not affecting code functionality) but just needed to add some error handling for them.
|
The UI looks great. However, there is a delay reordering tracks using musical characteristics |
|
Found issue for delay: root cause is due to not having "Custom Order" selected in the dropdown sorting options. Implementing fix to mimic this programmatically to avoid user interaction or issue. |
Also removed Duration as a custom sorting option since it already is provided by Spotify.
|
Implemented fix for above issue^^. |
skycube19
approved these changes
Oct 30, 2024
|
New fix works on my machine. Great job! |
rrk0804
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All back-end and API logic complete. Preset creation logic, and playlist dynamic reordering logic complete and tested.
Delay issue fixed.
Only issue left pertains to UI of the feature and permanently effecting the Spotify App instead of for just one instance on load.