feat: add multiplier to kerosine DV #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnkz
changed the title
coffeexcoin
reviewed
Dec 4, 2024
|
|
||
| uint256 dyadSupply = DYAD.totalSupply(); | ||
|
|
||
| uint256 tvl = _getTvl(); |
There was a problem hiding this comment.
This is a super expensive operation - are we able to bypass the check for TVL and instead just multiply the adjusted kerosene supply by dyadMultiplier?
For instance for 1.25x:
x = (c - d) / k
becomes
x = (c - d) / (1.25 * k)
It seems to me this should have the same effect?
There was a problem hiding this comment.
The original idea for the new kerosine deterministic value was:
x = (c - 1.25 * d) / k
Since the KeroseneVault contract is not upgradeable we cannot modify directly how the kero DV is calculated there, the only way was to use a new KerosineDenominator contract and calculate the denominator in such way that
(c - d) / new denom = (c - 1.25*d) / k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new way to calculate the kerosine denominator so
Where
xcan be set by the owner to be applied over time