This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Turbolinks iOS and Android app support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents having to log in every time the app is launched, or, every time the browser window is closed/opened on desktop.
Could be used later when taking advantage of rail's variants to provide unique views for the mobile apps.
Turbolinks requires form submissions to be remote. Additionally, by default devise won't try to redirect remote form submissions, so add `:js` as a navigational format.
danielwestendorf
changed the title
+ Memoize values + mobile_app_version shouldn't be predicate 🤦♂️
|
Do you need this merged in to master to keep making progress on the iOS/Android apps? |
|
Nope, not yet. I've got discussion points over at #10 as well as https://github.com/danielwestendorf/Droptune-iOS/issues |
danielwestendorf
changed the title
|
I'm confident this is in a good enough place to merge and deploy. Any additional changes backend will probably be around UI/UIX. |
|
@Shpigford forgot to tag you above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass of changes required to support iOS and Android apps. Probably more to come as the apps evolve.