Merge pull request #450 from hanadaUG/remove_button_session_feedback

Remove button of session's feedback in session detail screen
DroidKaigi · Jan 19, 2020 · 6c17b6c · 6c17b6c
2 parents 9275e7e + 230d3b1
commit 6c17b6c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 29 deletions.
diff --git a/...sion/src/main/java/io/github/droidkaigi/confsched2020/session/ui/SessionDetailFragment.kt b/...sion/src/main/java/io/github/droidkaigi/confsched2020/session/ui/SessionDetailFragment.kt
@@ -127,9 +127,6 @@ class SessionDetailFragment : DaggerFragment(R.layout.fragment_session_detail) {
         binding.sessionFavorite.setOnClickListener {
             sessionDetailViewModel.favorite(session)
         }
-        binding.survey.setOnClickListener {
-            findNavController().navigate(actionSessionToSurvey(session.id))
-        }
         binding.session = session
         setupSessionDescription(session.desc)
         binding.speechSession = (session as? SpeechSession)

diff --git a/feature/session/src/main/res/layout/fragment_session_detail.xml b/feature/session/src/main/res/layout/fragment_session_detail.xml
@@ -129,31 +129,6 @@
                     app:layout_constraintTop_toBottomOf="@id/duration_room"
                     />
 
-                <com.google.android.material.button.MaterialButton
-                    android:id="@+id/survey"
-                    style="@style/Widget.MaterialComponents.Button.OutlinedButton"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:layout_marginTop="8dp"
-                    android:insetTop="0dp"
-                    android:insetBottom="0dp"
-                    android:minHeight="36dp"
-                    android:paddingLeft="12dp"
-                    android:paddingRight="16dp"
-                    android:text="@string/session_survey_label"
-                    android:textAppearance="?attr/textAppearanceButton"
-                    android:textColor="@color/survey_button"
-                    app:icon="@drawable/ic_add_comment_24dp"
-                    app:iconPadding="8dp"
-                    app:iconSize="20dp"
-                    app:iconTint="@color/survey_button"
-                    app:layout_constraintStart_toStartOf="@id/guideline_start"
-                    app:layout_constraintTop_toBottomOf="@id/tags"
-                    app:strokeColor="@color/survey_button"
-                    app:strokeWidth="1dp"
-                    tools:enabled="false"
-                    />
-
                 <View
                     android:id="@+id/divider_survey_and_text"
                     android:layout_width="0dp"
@@ -162,7 +137,7 @@
                     android:background="@color/black_alpha_12"
                     app:layout_constraintEnd_toEndOf="@id/guideline_end"
                     app:layout_constraintStart_toStartOf="@id/guideline_start"
-                    app:layout_constraintTop_toBottomOf="@id/survey"
+                    app:layout_constraintTop_toBottomOf="@id/tags"
                     />
 
                 <TextView