Fix

Draco-lang · Oct 28, 2024 · d66be23 · d66be23
1 parent 2e22ffe
commit d66be23
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/src/Draco.Compiler/Internal/FlowAnalysis/CompleteFlowAnalysis.cs b/src/Draco.Compiler/Internal/FlowAnalysis/CompleteFlowAnalysis.cs
@@ -39,11 +39,11 @@ public static void AnalyzeFunction(SourceFunctionSymbol symbol, DiagnosticBag di
     }
 
     /// <summary>
-    /// Analyzes a global value.
+    /// Analyzes a global field.
     /// </summary>
     /// <param name="symbol">The symbol to analyze.</param>
     /// <param name="diagnostics">The diagnostics to report errors to.</param>
-    public static void AnalyzeValue(SourceFieldSymbol symbol, DiagnosticBag diagnostics)
+    public static void AnalyzeField(SourceFieldSymbol symbol, DiagnosticBag diagnostics)
     {
         if (symbol.Value is null)
         {
@@ -63,8 +63,12 @@ public static void AnalyzeValue(SourceFieldSymbol symbol, DiagnosticBag diagnost
         symbol.Value.Accept(analysis);
     }
 
-    // TODO: Copypasta from SourceFieldSymbol
-    public static void AnalyzeValue(SourceAutoPropertySymbol symbol, DiagnosticBag diagnostics)
+    /// <summary>
+    /// Analyzes a global property.
+    /// </summary>
+    /// <param name="symbol">The symbol to analyze.</param>
+    /// <param name="diagnostics">The diagnostics to report errors to.</param>
+    public static void AnalyzeProperty(SourceAutoPropertySymbol symbol, DiagnosticBag diagnostics)
     {
         if (symbol.Value is null)
         {

diff --git a/src/Draco.Compiler/Internal/OptimizingIr/Codegen/ModuleCodegen.cs b/src/Draco.Compiler/Internal/OptimizingIr/Codegen/ModuleCodegen.cs
@@ -68,7 +68,6 @@ public override void VisitField(FieldSymbol fieldSymbol)
         }
     }
 
-    // TODO: Copypasta from VisitField
     public override void VisitProperty(PropertySymbol propertySymbol)
     {
         // TODO: Not flexible, won't work for non-auto props

diff --git a/src/Draco.Compiler/Internal/Symbols/Source/SourceAutoPropertySymbol.cs b/src/Draco.Compiler/Internal/Symbols/Source/SourceAutoPropertySymbol.cs
@@ -40,7 +40,7 @@ public override void Bind(IBinderProvider binderProvider)
         this.BindTypeAndValueIfNeeded(binderProvider);
 
         // Flow analysis
-        CompleteFlowAnalysis.AnalyzeValue(this, binderProvider.DiagnosticBag);
+        CompleteFlowAnalysis.AnalyzeProperty(this, binderProvider.DiagnosticBag);
     }
 
     private (TypeSymbol Type, BoundExpression? Value) BindTypeAndValueIfNeeded(IBinderProvider binderProvider)

diff --git a/src/Draco.Compiler/Internal/Symbols/Source/SourceFieldSymbol.cs b/src/Draco.Compiler/Internal/Symbols/Source/SourceFieldSymbol.cs
@@ -37,7 +37,7 @@ public override void Bind(IBinderProvider binderProvider)
         this.BindTypeAndValueIfNeeded(binderProvider);
 
         // Flow analysis
-        CompleteFlowAnalysis.AnalyzeValue(this, binderProvider.DiagnosticBag);
+        CompleteFlowAnalysis.AnalyzeField(this, binderProvider.DiagnosticBag);
     }
 
     private (TypeSymbol Type, BoundExpression? Value) BindTypeAndValueIfNeeded(IBinderProvider binderProvider)
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,6 @@ public override void VisitField(FieldSymbol fieldSymbol) @@
             }
         }
-        // TODO: Copypasta from VisitField
         public override void VisitProperty(PropertySymbol propertySymbol)
         {
             // TODO: Not flexible, won't work for non-auto props
@@ Expand Down @@