Skip to content

Commit

Permalink
Update JsonRpcConnection.cs
Browse files Browse the repository at this point in the history
  • Loading branch information
@LPeter1997
LPeter1997 committed Oct 1, 2023
1 parent e2734b3 commit 71f8eb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Draco.JsonRpc/JsonRpcConnection.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ private bool TryParseMessage(
return false;
}

private async Task<TMessage?> ProcessMessage(TMessage message)
private async Task<TMessage?> ProcessRequestOrNotification(TMessage message)

Check warning on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-ubuntu-latest 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check failure on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-ubuntu-latest 

'JsonRpcConnection<TMessage>.ProcessRequestOrNotification(TMessage)': not all code paths return a value

Check warning on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-ubuntu-latest 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check failure on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-ubuntu-latest 

'JsonRpcConnection<TMessage>.ProcessRequestOrNotification(TMessage)': not all code paths return a value

Check warning on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-macOS-latest 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check failure on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-macOS-latest 

'JsonRpcConnection<TMessage>.ProcessRequestOrNotification(TMessage)': not all code paths return a value

Check warning on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-macOS-latest 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check failure on line 187 in src/Draco.JsonRpc/JsonRpcConnection.cs

View workflow job for this annotation

GitHub Actions / tests-macOS-latest 

'JsonRpcConnection<TMessage>.ProcessRequestOrNotification(TMessage)': not all code paths return a value
{
var (method, @params, id) = this.ExtractMessageInfo(message);

Expand Down

0 comments on commit 71f8eb2

Please sign in to comment.