Add P and a tag support on nostr zaps #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zapNote P = pubkey from the zap sender a = is an optional event coordinate that allows tipping parameterized replaceable events such as NIP-23 long-form notes See https://github.com/nostr-protocol/nips/blob/master/57.md#appendix-e-zap-receipt-event
Sebastix
changed the title
|
Tagging you @Dolu89 here for the visibility |
|
Sure. @mutatrum Let us know your thoughts on this 👍 |
|
I merged it into my fork, I'm 'testing' it now in production. |
|
@mutatrum How's the testing going :) |
|
Looks fine to me, nothing broke. But not sure how to test the effect of these new tags? |
|
@mutatrum Kieren, developer of Snort and Zap.stream pointed out this to me as that zap.stream uses the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the added
Pandatag on zap events in NIP-57.The validation of a tag is still a TODO (I'm looking for existing snippet on validating that value from other JavaScript build Nostr projects).