Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Check if querystring isset before adding questionmark to destinationUrl #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dennisadriaans
Copy link

@dennisadriaans dennisadriaans commented Mar 5, 2023

Google complains about an alternate page with proper canonical tag because for every redirect there is a question mark added to the destination URL.

@idleog
Copy link

idleog commented Mar 8, 2023

It seems that this commit does not remove the question-mark.

@idleog
Copy link

idleog commented Mar 8, 2023

Shouldn't it be on line 90

if ($queryString) { // instead of isset($querystring)
$destinationUrl .= "?" . $queryString;
}

@knightmediaweb
Copy link

if ($queryString) { // instead of isset($querystring)
$destinationUrl .= "?" . $queryString;
}

Can confirm this works.

@meredevelopment
Copy link

Confirmed, would you consider updating your PR please @dennisadriaans? And then hopefully someone can merge it in 🙌

@dennisadriaans
Copy link
Author

dennisadriaans commented Apr 24, 2023

I updated the PR as requested.

@MatthiasBrodelet
Copy link

Can someone merge this please?

@frederikvdbe
Copy link

Can confirm this works. Please merge 🙏

@duncandejong
Copy link

I also can confirm this works. I hope this gets merged soon.

@dr-codswallop
Copy link

Is this still waiting to merge the fix? v2.0.1 installed and still has the "?" on redirects.

@oaklees
Copy link

oaklees commented Jul 19, 2024

Running into this too - would we be able to get this merged at all please?

@MatthiasBrodelet
Copy link

Don't bother.
I have emailed their company a year ago and never even got a reply.
This project is abandoned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants