-
Notifications
You must be signed in to change notification settings - Fork 35
Check if querystring isset before adding questionmark to destinationUrl #137
base: master
Are you sure you want to change the base?
Conversation
It seems that this commit does not remove the question-mark. |
Shouldn't it be on line 90 if ($queryString) { // instead of isset($querystring) |
Can confirm this works. |
Confirmed, would you consider updating your PR please @dennisadriaans? And then hopefully someone can merge it in 🙌 |
I updated the PR as requested. |
Can someone merge this please? |
Can confirm this works. Please merge 🙏 |
I also can confirm this works. I hope this gets merged soon. |
Is this still waiting to merge the fix? v2.0.1 installed and still has the "?" on redirects. |
Running into this too - would we be able to get this merged at all please? |
Don't bother. |
Google complains about an alternate page with proper canonical tag because for every redirect there is a question mark added to the destination URL.