Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move components and update CoreComponents handling #5

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

TheFirstAvenger
Copy link
Member

Moves components into components subdirectory, fixes #1. Rename HTML.ex, fixes #2. Update handling of CoreComponents.

Copy link
Member

@merhard merhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting the structure to be the following:

lib/
  - components/
    - station_ui/
      - station_ui.html.ex
      - html/
        - {<component files>}.ex

NOTE the downcased html folder name.

Also which of the following should it be?

  1. lib/components/station_ui.html.ex
  2. lib/components/station_ui/station_ui.html.ex

@bcardarella
Copy link
Member

lib/components/core_components_station_ui.html.ex

This way it is sorted next to other core component files.

@bcardarella
Copy link
Member

ehhhh, now that I'm seeing it in print I'm less convinced. Thoughts?

@TheFirstAvenger
Copy link
Member Author

@merhard I actually have HTML lowercased on my end, but didn't have git config core.ignorecase false set. Just fixed that.

If we have it in it's own subfolder in components, there should only be our stuff in there, making our upgrade path easier in the future as we own that directory.

@bcardarella I feel calling it core_components_station_ui is a disservice because yes it replaces the core_components, but that is just a fraction of what it does.

@TheFirstAvenger TheFirstAvenger merged commit 8b4427c into main Nov 15, 2024
4 checks passed
@TheFirstAvenger TheFirstAvenger deleted the mb-1-and-2-move-components branch November 15, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants