Defer initialization and allow for deferred retries #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(but will fail right after that if so).
…pervision as permanent worker that may transiently have failures due to Internet connectivity.
…reading config from a database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to take a look at your contribution guidelines as mentioned in your README.md but it looks like the link to that is broken.
If you're not accepting contributions, no sweat, I just thought I'd contribute this back now that it's been in production with us for a few months. Mainly the issue of potentially failing application startup is what I wanted to fix, see comments in worker.ex
Thanks for a very useful bit of code.
Cheers,
Jói