Improve inspect readability
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging code backed by `StoreModel`, I had issues understanding some model attributes, as those that were more complex objects just printed the attribute's class and its memory address. I saw something like: ``` => #<Content::Text type: text, text: #<Content::Text::Base:0x000000011a9716f0>> ``` By contrast, the default Ruby `inspect` implementation calls `inspect` on all the object's instance variables: ``` => #<OuterClass:0x0000000104ac87f8 @Attribute=#<InnerClass:0x000000010466cf60 @text="string">> ``` Also, the strings are not quoted, making strings like `"nil"` and `"false"` show up as `nil` and `false`, which may lead to confusion. This commit changes the `inspect` implementation to call `inspect` on the model attributes, fixing the issues stated above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging code backed by
StoreModel, I had issues understanding some model attributes, as those that were more complex objects just printed the attribute's class and its memory address.I saw something like:
By contrast, the default Ruby
inspectimplementation callsinspecton all the object's instance variables:Also, the strings are not quoted, making strings like
"nil"and"false"show up asnilandfalse, which may lead to confusion.This commit changes the
inspectimplementation to callinspecton the model attributes, fixing the issues stated above.