Skip to content

Commit

Permalink
Merge pull request #16 from mardaravicius/update-xs-effect-amount-doc…
Browse files Browse the repository at this point in the history
…-about-attack-armor-changing

update xs effect amount doc about attack/armor changing
  • Loading branch information
KSneijders authored Dec 6, 2024
2 parents eadeb1f + 16eb1dd commit d447099
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 11 deletions.
12 changes: 7 additions & 5 deletions docs/general/xs/bugs/Effect Amount.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,19 @@ Reproduction Steps:
void main() {
const int cGenghisKhan = 731;
const int cPierce = 3;
// Both of these work correctly as expected

// These do not do anything.
xsEffectAmount(cSetAttribute, cGenghisKhan, cAttack, cPierce*65536 + 5);
xsEffectAmount(cSetAttribute, cGenghisKhan, cArmor, cPierce*65536 + 5);

// These however do not do anything.
xsEffectAmount(cAddAttribute, cGenghisKhan, cAttack, cPierce*65536 + 5);
xsEffectAmount(cMulAttribute, cGenghisKhan, cArmor, cPierce*65536 + 5);

// To make cAddAttribute and cMulAttribute work, we need to currently use the old format:
// To make cSetAttribute and cAddAttribute work, we need to currently use this format:
// xsEffectAmount(cSetAttribute, cGenghisKhan, cAttack, cPierce*256 + 5);
// xsEffectAmount(cSetAttribute, cGenghisKhan, cArmor, cPierce*256 + 5);
// xsEffectAmount(cAddAttribute, cGenghisKhan, cAttack, cPierce*256 + 5);

// cMulAttribute seems to do something in the correct format but not multiply:
// xsEffectAmount(cMulAttribute, cGenghisKhan, cArmor, cPierce*256 + 5);
}
```
Expand Down
12 changes: 7 additions & 5 deletions docs/general/xs/bugs/bugged/effect_amount2.xs
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
void main() {
const int cGenghisKhan = 731;
const int cPierce = 3;
// Both of these work correctly as expected

// These do not do anything.
xsEffectAmount(cSetAttribute, cGenghisKhan, cAttack, cPierce*65536 + 5);
xsEffectAmount(cSetAttribute, cGenghisKhan, cArmor, cPierce*65536 + 5);

// These however do not do anything.
xsEffectAmount(cAddAttribute, cGenghisKhan, cAttack, cPierce*65536 + 5);
xsEffectAmount(cMulAttribute, cGenghisKhan, cArmor, cPierce*65536 + 5);

// To make cAddAttribute and cMulAttribute work, we need to currently use the old format:
// To make cSetAttribute and cAddAttribute work, we need to currently use this format:
// xsEffectAmount(cSetAttribute, cGenghisKhan, cAttack, cPierce*256 + 5);
// xsEffectAmount(cSetAttribute, cGenghisKhan, cArmor, cPierce*256 + 5);
// xsEffectAmount(cAddAttribute, cGenghisKhan, cAttack, cPierce*256 + 5);

// cMulAttribute seems to do something in the correct format but not multiply:
// xsEffectAmount(cMulAttribute, cGenghisKhan, cArmor, cPierce*256 + 5);
}
2 changes: 1 addition & 1 deletion docs/general/xs/bugs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ If you know of a bug that is not documented here, or if a bug listed here is act

Game Version: `101.102.47822.0 (#113358) 14355041`

Last Updated: `05.06.2024`
Last Updated: `01.12.2024`

Game Platform: Steam

Expand Down

0 comments on commit d447099

Please sign in to comment.