Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add moonbeam network #5842

Closed

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Mar 9, 2022

Description

Closes #5827 #5826 #5837

Integrate Ecosystem and Network Moonbem

Exchanges

  • BeamSwap. ✅
  • Stella Swap ✅
  • PadSwap ✅

Maskbook core contracts

Assets

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Jack-Works
Jack-Works previously approved these changes Mar 12, 2022
@guanbinrui
Copy link
Member

Hi @developerfred, Plz resolve those conflicts.

@guanbinrui
Copy link
Member

@guanbinrui
Copy link
Member

Hi @developerfred Plz fix those CI errors.

@wenluomask
Copy link
Contributor

1.If I use Mask wallet, transactions didn't provide Max priority fee and Max fee;
截屏2022-05-03 下午9 17 09
截屏2022-05-03 下午9 18 33

  1. Dashboard cannot get assets in Moonbeam Network;

截屏2022-05-03 下午9 18 59

  1. US dollar value of token wasn't added;

截屏2022-05-03 下午9 19 06

  1. Since no any DEX supports swap in Moonbeam, why do we open swap in Mask?

@developerfred
Copy link
Contributor Author

developerfred commented May 5, 2022

Screenshot 2022-05-05 at 22 12 28

@Jack-Works
Copy link
Member

there're too many merge conflicts 👀

@wenluomask
Copy link
Contributor

wenluomask commented May 23, 2022

Hi @developerfred ,

I have checked the latest version of pr just now. I found out that #1-4 were not fixed yet.

For #1, since you are using gas price instead of priority fee and max fee for gas setting, it is incorrect for Moonbeam. Moonbeam supports EIP-1559, so please change back to EIP-1559 transaction gas setting.

For #4, if Moonbeam did support in BeamSwap, Stella Swap and PadSwap as you checked, the token list should not be empty. Could you check again?
Screen Shot 2022-05-23 at 11 52 05 AM

developerfred and others added 7 commits May 23, 2022 22:57
* refactor: redpacket share text

* fix: promote redpacket

* fix: promote gitcoin, trader, and ITO

* fix: decorate encrypted text

* fix: share after setting up pfp

* fix: follow up reviews

* fix: promote savings

* fix: collectible and snapshot

* fix: fix after rebasing

* fix: fix typo

* fix: decorate result

* fix: add missing description

* fix: replace useCallback with useAsyncFn

* fixup! fix: replace useCallback with useAsyncFn

* fix: revert
@developerfred developerfred force-pushed the feat/moonbean-network branch from 83aa9b8 to 526a359 Compare May 30, 2022 23:58
@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Will Not Fix label Sep 8, 2022
@stale stale bot closed this Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bounty] Integrate Beamswap, A DEX Providing Liquidity and Peer to Peer Transactions, into Mask Plugin
7 participants