Fix modules for newest pylint in ansible-test (containers#286)

contrib/ansible-lint.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+mkdir -p /tmp/ansible-lint-installs
+mkdir -p /tmp/ansible-lint-collection
+rm -rf /tmp/ansible-lint-collection/*
+ansible-galaxy collection build --output-path /tmp/ansible-lint-collection --force
+pushd /tmp/ansible-lint-collection/
+ansible-galaxy collection install -vvv --force $(ls /tmp/ansible-lint-collection/) -p /tmp/ansible-lint-installs
+pushd /tmp/ansible-lint-installs/ansible_collections/containers/podman
+ansible-test sanity --docker --color --truncate 0 --no-redact --no-pip-check --python 3.9 -v plugins/ tests/
+popd
+popd

plugins/module_utils/podman/podman_pod_lib.py

@@ -312,8 +312,8 @@ def diffparam_infra_image(self):
             after = self.params['infra_image']
         before = before.replace(":latest", "")
         after = after.replace(":latest", "")
-        before = before.split("/")[-1]
-        after = after.split("/")[-1]
+        before = before.split("/")[-1]  # pylint: disable=W,C,R
+        after = after.split("/")[-1]  # pylint: disable=W,C,R
         return self._diff_update_and_compare('infra_image', before, after)
 
     # TODO(sshnaidm): https://github.com/containers/podman/pull/6956

plugins/modules/podman_containers.py

@@ -53,8 +53,8 @@
 
 
 def combine(results):
-    changed = any([i.get('changed', False) for i in results])
-    failed = any([i.get('failed', False) for i in results])
+    changed = any(i.get('changed', False) for i in results)
+    failed = any(i.get('failed', False) for i in results)
     actions = []
     podman_actions = []
     containers = []