Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI redaction #164

Merged
merged 13 commits into from
Dec 8, 2023
Merged

UI redaction #164

merged 13 commits into from
Dec 8, 2023

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Oct 4, 2023

This contains the 'quick' and 'messy' fix for redaction progress as a temp fix while the new frontend is being worked on.

@marySalvi marySalvi requested a review from manthey November 7, 2023 17:02
@marySalvi
Copy link
Collaborator Author

This currently hangs forever and I am stumped. To test have to windows open one to localhost:8000 the other to localhost:8000/websocket. Ideally when you make a selection for redaction the progress would be logged to the websocket endpoint. It does not.

@marySalvi marySalvi marked this pull request as ready for review December 1, 2023 23:19
@manthey
Copy link
Contributor

manthey commented Dec 5, 2023

I see this says "Redacting image out of 25" but there is no count in that message and it doesn't update.

@marySalvi
Copy link
Collaborator Author

I see this says "Redacting image out of 25" but there is no count in that message and it doesn't update.

I will take a look

@marySalvi
Copy link
Collaborator Author

@manthey This should be fixed in fae0172. The url for the websocket had been hard coded which breaks the cli.

Copy link
Contributor

@manthey manthey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a quick and messy fix.

@marySalvi marySalvi merged commit c1cc550 into main Dec 8, 2023
4 checks passed
@marySalvi marySalvi deleted the ui-redaction branch December 8, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants