Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIENT LIST cmd #1360

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kakdeykaushik
Copy link
Contributor

resolves #1134

@kakdeykaushik
Copy link
Contributor Author

@JyotinderSingh this is inital version of changes, have a look and let me know if any code structure changes are required.

I have created a slice of clients which contains all the clients connected to the resp server.
Ideally this slice should reside in iothread package itself. And evalClient fn (eval package) should import it, but this would not work since current dependency chart looks like this and importing iothread package in eval package creates circular dependency.

flowchart TD
    A[server] --> B("iothread
    IOThread interface
    BaseIOThread struct
    ")
    B --> C(ops)
    C -->D(comm)
    C --> E(cmd)
    C -->F("eval
    EvalResponse")


    B --> Z(shard)
    Z --> C
    Z --> F
  

Loading

My solution - I have pulled out IOThread interface out in a new global package(we can think of a better name) and kept the slice of clients in eval package.

This solution works but I think this is not the ideal way to do it. I'd like your suggestions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for command CLIENT LIST
1 participant