Support JSON.ARRINDEX #486 #1348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamskp11
commented
Dec 3, 2024
iamskp11
commented
Dec 3, 2024
iamskp11
commented
Dec 3, 2024
|
Hey @JyotinderSingh @apoorvyadav1111 , requesting you to review this PR. |
apoorvyadav1111
approved these changes
Dec 8, 2024
| @@ -58,6 +58,8 @@ func runIntegrationTests(t *testing.T, exec *WebsocketCommandExecutor, conn *web | |||
| assert.True(t, result.(float64) <= out.(float64) && result.(float64) > 0, "Expected %v to be within 0 to %v", result, out) | |||
| case "json_equal": | |||
| assert.JSONEq(t, out.(string), result.(string)) | |||
| case "deep_equal": | |||
| assert.True(t, testutils.ArraysArePermutations(result.([]interface{}), out.([]interface{}))) | |||
There was a problem hiding this comment.
Can we try using ElementsMatch instead of a custom function, we are migrating from this function.
apoorvyadav1111
requested changes
Dec 8, 2024
|
Hi @iamskp11, I reran the CI for the PR. Also, I would like to request to change the permutation function in other two files as well. Thanks |
|
Hi @iamskp11 , thanks for these changes. Could you please rebase the PR? I can merge once the CI checks are passed. |
apoorvyadav1111
approved these changes
Dec 9, 2024
|
@apoorvyadav1111 Pls do not merge. Getting some issues related to HTTP tests since cmd_meta.go is deleted in latest master. Will debug and fix today later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #486.