Use code to draw button effect instead of pictures #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealMoeder
approved these changes
Feb 19, 2019
|
Does this have real ROI and actually make widgets easier to use? It will require users to update their filesystem...something we try not to require as much as possible. I tested that it doesn't crash when the old images are used, but it also will appear to be a graphics bug in that case. |
| {NULL, 64, 16, 0, 0}, /*FILE_BTN64_16 */ | ||
| {NULL, 48, 16, 0, 0}, /*FILE_BTN48_16 */ | ||
| {NULL, 32, 16, 0, 0}, /*FILE_BTN32_16 */ | ||
| {NULL,192, 16, 1, 0}, /*FILE_SPIN192 */ |
There was a problem hiding this comment.
Lint Error:
41: Missing space after ,
| u16 uppercolor = 0; | ||
| u16 bottomcolor = 0; | ||
|
|
||
| switch(map->x_off) { |
There was a problem hiding this comment.
Lint Error:
819: Missing space before ( in switch(
| y_end = size / 3; | ||
|
|
||
| // draw additional arrows | ||
| switch(map->y_off) |
There was a problem hiding this comment.
Lint Error:
879: Missing space before ( in switch(
howard0su
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves SPI flash space for the color screen Tx with small SPI flash or no flash.