Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per datasheet to adjust delay for tw8816 #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

howard0su
Copy link
Contributor

No description provided.

@howard0su
Copy link
Contributor Author

Validate on my own Tx

@DeviationTX DeviationTX deleted a comment from howard0su Jan 20, 2019
@PhracturedBlue
Copy link
Contributor

well...it is really difficult to review this patch with the style fixes applied.
Also, I don't like some of the formatting changes (like moving curly-braces to the same line...This is one of those things that I think is context specific. I think I want to separate cleanup patches from code-change patches.

@howard0su
Copy link
Contributor Author

howard0su commented Jan 20, 2019 via email

@PhracturedBlue
Copy link
Contributor

what is the plan for this?
My concern is that there are many variants of the tw8816 (I think we've seen 6 different revisions in use by Walkera). They all had different quirks, so I'm very reluctant to make a change that the data-sheet says is ok without having confidence it is ok on multiple actual transmitters. On the other hand it is almost 0.5sec of wait that you can remove which is quite a lot. I need to check my F12E and see what revision of the TW8816 it has.

@howard0su
Copy link
Contributor Author

i think I should revert the change on msleep.

this change was intent to remove Delay calls. I am thinking to replace Delay with usleep(1) which is almost same as the amount of time Delay actual cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants