-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per datasheet to adjust delay for tw8816 #619
base: master
Are you sure you want to change the base?
Conversation
Validate on my own Tx |
well...it is really difficult to review this patch with the style fixes applied. |
no intention to check this in. This is another testing. I think
clang-format overall is useful when we need dealing the whole code base.
What's your plan then? Do you want to have one big change to clean all of
them? If you like to do so, let's coordinate with the devs who has the
pending PR on hand. or your lint gives the warnings and expect we clean it
up in a relative long run.
…On Sun, Jan 20, 2019 at 10:01 PM PhracturedBlue ***@***.***> wrote:
well...it is really difficult to review this patch with the style fixes
applied.
Also, I don't like some of the formatting changes (like moving
curly-braces to the same line...This is one of those things that I think is
context specific. I think I want to separate cleanup patches from
code-change patches.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#619 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuzRHxgjhJVaPYGNI4WQ5B6tx9gsbCsks5vFHbHgaJpZM4aJcHe>
.
--
-Howard
|
e2a84ae
to
39d734a
Compare
39d734a
to
74a2a5e
Compare
what is the plan for this? |
i think I should revert the change on msleep. this change was intent to remove Delay calls. I am thinking to replace Delay with usleep(1) which is almost same as the amount of time Delay actual cause. |
No description provided.