Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved Issue #68 [FEATURE] Tablet Mode for Teams Section [GSSoC'23] #110

Open
wants to merge 9 commits into
base: Development
Choose a base branch
from
Open

Solved Issue #68 [FEATURE] Tablet Mode for Teams Section [GSSoC'23] #110

wants to merge 9 commits into from

Conversation

vishnu9865
Copy link
Contributor

@vishnu9865 vishnu9865 commented Jun 1, 2023 •
edited
Loading

Description

Feat: enable Tablet Mode for Teams Section

Related Issue(s)

Closes #68

Proposed Changes

  • Edited _app.js (temp fix for minimizing conflicts with other issues).
  • Created Developer.module.css.
  • Modified CSS for Tablet Mode.
  • Fixed layout bugs in Tablet Mode.
  • Edited CSS to ease transition to TailwindCSS.

Screenshots (if applicable)

image

Checklist

  • I have tested the changes locally and they are working as expected.
  • I have added any necessary documentation or updated existing documentation.
  • I have reviewed the code changes to ensure they adhere to the project's coding standards.
  • I have added appropriate labels to this pull request.

@vishnu9865
feat: enable Tablet Mode for Teams Section
b68b4c5 
 - Created Developer.module.css.
 - Modified CSS for Tablet Mode.
 - Fixed layout bugs in Tablet Mode.
 - Edited CSS to ease transition to TailwindCSS.
kaustubhai
kaustubhai reviewed Jun 3, 2023
View reviewed changes
pages/_app.js Outdated Show resolved Hide resolved
@kaustubhai
Copy link
Contributor

kaustubhai commented Jun 3, 2023 •
edited
Loading

image

This is not an accurate design @vishnu9865. You will have to push a little harder, this is the first time we are developing a page for tablet so you will have to adjust minor details of components being used in every page as well

@vishnu9865
Copy link
Contributor Author

image

This is not an accurate design @vishnu9865. You will have to push a little harder, this is the first time we are developing a page for tablet so you will have to adjust minor details of components being used in every page as well

@kaustubhai Sir,
Sorry sir, I thought I should not tamper with navbar code as my PR may have conflicts with any other contributor working on Navbar alignment or any navbar related issue.
Is it okay for me to work on navbar ? If so I am very happy solve the issue in this PR.
Thank you for your time with this PR.
Regards,
Jeyavishnu S @vishnu9865

vishnu9865 added 4 commits June 4, 2023 07:47
@vishnu9865
fix: modify tablet function
e92a59e 
 - Tablet function now takes nextjs router object as argument.
 - Anyone wanting to enable a page can add to the conditions in the return statement easily.
@vishnu9865
Merge branch 'Deveimer:Development' into VOVOCA-68
c9d4f6f
@vishnu9865
fix: Remove console logs
d7d830b 
 - Removed uneccessary console logs in the code.
@vishnu9865
Merge branch 'VOVOCA-68' of https://github.com/vishnu9865/vovoca-fron…
71acf21 
…tend into VOVOCA-68
@kaustubhai
Copy link
Contributor

kaustubhai commented Jun 4, 2023 •
edited
Loading

@kaustubhai Sir, Sorry sir, I thought I should not tamper with navbar code as my PR may have conflicts with any other contributor working on Navbar alignment or any navbar related issue. Is it okay for me to work on navbar ? If so I am very happy solve the issue in this PR. Thank you for your time with this PR. Regards, Jeyavishnu S @vishnu9865

Yeah yeah please go ahead. I think it was mentioned in the issue itself that this is the first page that was being migrated to tablet mode. Kudos for thinking for conflicts but, you had a go-ahead already to work on that

@vishnu9865
Copy link
Contributor Author

Ok sir, working on it 🚀🚀🚀

vishnu9865 added 2 commits June 7, 2023 17:00
@vishnu9865
fix: edit navbar for tablet mode.
3cd1745 
 - navbar changes layout to a flex container with space-between.
 - Mobile navbar becomes visible at max-width: 775px
 - Changes to VOVOCA icon in navbar for better layout and responsiveness.
@vishnu9865
fix: further modify Navbar
0dd74b6 
 - additional bug fixed for the tablet mode navbar.
@vishnu9865
Copy link
Contributor Author

@kaustubhai Sir,
I have made some changes to the Navbar code.
Please feel free to ask for any changes required and sorry for any inconveniences caused.
Regards,
Jeyavishnu @vishnu9865
image

@kaustubhai
Copy link
Contributor

Sharing few pointers with you, I think it will look better then:

  1. Remove the Home link from navbar for tab and desktop
  2. Decrease the Dashboard button size (Can remove the icon and decrease the font-size) only for tab
  3. Make button-group right-aligned and vovoca to the left as it is in desktop

@vishnu9865
Copy link
Contributor Author

@kaustubhai Ok sir, working on it.

vishnu9865 added 2 commits June 8, 2023 17:19
@vishnu9865
fix: update navbar design
df7c6bc 
 - Remove Home button
 - Remove Flex layout and make navbar group right aligned.
@vishnu9865
fix: remove dashboard icon in tablet mode
6f8cf23 
 - edited CSS rules to remove icon in tablet mode.
@vishnu9865
Copy link
Contributor Author

@kaustubhai Sir,
I made the following changes. 👍
image

@vishnu9865 vishnu9865 requested a review from kaustubhai June 11, 2023 04:34
@kaustubhai
Copy link
Contributor

In review @vishnu9865

@vishnu9865
Copy link
Contributor Author

In review @vishnu9865

@kaustubhai Sir, ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaustubhai kaustubhai Awaiting requested review from kaustubhai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Tablet Mode for Teams Section
2 participants
@vishnu9865 @kaustubhai