Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix senate #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Fix senate #25

wants to merge 2 commits into from

Conversation

rdhyee
Copy link

@rdhyee rdhyee commented Oct 9, 2016

A start to fixing candidatebot to work for Senate races.

Re https://devprogress.slack.com/archives/proj-candidatebot/p1475791952000002:

Works for wikipedia's house and governor's pages. Not senate yet, because that has 'state (blah blah something)' instead of 'state' as a column. Trivially fixable,...

Current status: tests fixed and I have a Jupyter notebook to write a CSV.

Copy link
Contributor

@whereistanya whereistanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ipython notebook file a step along the way, or the final product?

I suggest you send the test fixes as a PR on their own, so we can get that committed.

@@ -22,6 +23,7 @@ def test_normalize_name(self):
for k in cases:
self.assertEqual(candidate.normalize_name(k), cases[k])

@pytest.mark.skip(reason="candidate.check_field has been removed")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rip the test out instead, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants