Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:static class blocks are not enabled babel error #8267

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

Bayheck
Copy link
Collaborator

@Bayheck Bayheck commented Aug 27, 2024

Purpose

Describe the problem you want to address or the feature you want to implement.

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.

References

closes #8245

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@testcafe-need-response-bot testcafe-need-response-bot bot added the STATE: Need response An issue that requires a response or attention from the team. label Aug 27, 2024
@Bayheck Bayheck removed the STATE: Need response An issue that requires a response or attention from the team. label Aug 27, 2024
@Bayheck Bayheck marked this pull request as ready for review August 29, 2024 07:00
@Bayheck Bayheck requested a review from aleks-pro as a code owner August 29, 2024 07:00
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it's regression, we haven't handled this kind of field before, moreover, I can't say that it's a fix, I think it's a small feature. So it's not the appropriate place for a test, also we already have some server compile tests there and it's better to test this behavior there because functional tests are heavier than server tests

Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you fix the @types/node version?

@aleks-pro aleks-pro merged commit 647ecae into DevExpress:master Sep 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Static class blocks are not enabled" in Node 20
4 participants