Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should log concurrent requests (closes #7977) #7990

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

AlexKamaev
Copy link
Contributor

@AlexKamaev AlexKamaev commented Aug 31, 2023

Using only requestId for the key is not enough, since in concurrent tests the keys can be the same. I added the sessionId (testRunId) to the key.

@AlexKamaev AlexKamaev temporarily deployed to CI August 31, 2023 14:19 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 06:29 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 06:52 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 07:28 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 08:41 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 09:19 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 09:40 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 09:43 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 09:52 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI September 4, 2023 12:46 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev marked this pull request as ready for review September 4, 2023 14:15
@miherlosev miherlosev merged commit e4f0608 into DevExpress:master Sep 5, 2023
3 checks passed
@github-actions
Copy link

Release v3.4.0-rc.1 addresses this.

2 similar comments
@github-actions
Copy link

Release v3.4.0-rc.1 addresses this.

@github-actions
Copy link

Release v3.4.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants