Skip to content

Commit

Permalink
refactor: removed IE leftovers from test\functional (#7993)
Browse files Browse the repository at this point in the history
<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
_Describe the problem you want to address or the feature you want to
implement._

## Approach
_Describe how your changes address the issue or implement the desired
functionality in as much detail as possible._

## References
_Provide a link to the existing issue(s), if any._

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail
  • Loading branch information
Aleksey28 authored Sep 11, 2023
1 parent 5492810 commit be86b68
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
5 changes: 1 addition & 4 deletions test/functional/assertion-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,7 @@ exports.checkUserAgent = function (errs, alias) {
const parsedUA = parseUserAgent(errs[0]);
const prettyUA = parsedUA.prettyUserAgent.toLowerCase();

// NOTE: the "ie" alias corresponds to the "internet explorer" lowered part of a compact user agent string (GH-481)
const expectedBrowserName = alias === 'ie' ? 'internet explorer' : alias;

expect(prettyUA.indexOf(expectedBrowserName)).eql(0, prettyUA + ' doesn\'t start with "' + expectedBrowserName + '"');
expect(prettyUA.indexOf(alias)).eql(0, prettyUA + ' doesn\'t start with "' + alias + '"');
};

exports.SCREENSHOTS_PATH = SCREENSHOTS_PATH;
Expand Down
7 changes: 0 additions & 7 deletions test/functional/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const browserProviderNames = {

const testingEnvironmentNames = {
mobileBrowsers: 'mobile-browsers',
localBrowsersIE: 'local-browsers-ie',
localBrowsersChromeFirefox: 'local-browsers-chrome-firefox',
localBrowsers: 'local-browsers',
localChrome: 'local-chrome',
Expand Down Expand Up @@ -52,12 +51,6 @@ testingEnvironments[testingEnvironmentNames.localBrowsers] = {
browserName: 'chrome',
alias: 'chrome',
},
{
platform: 'Windows 10',
browserName: 'ie',
version: '11.0',
alias: 'ie',
},
{
platform: 'Windows 10',
browserName: 'firefox',
Expand Down

0 comments on commit be86b68

Please sign in to comment.